exozyme/exozyme
7
12
Fork 0
Code Issues 4 Pull requests Projects Releases 39 Wiki Activity

mx-puppet-discord crashing #152

New issue
Closed
opened 2022-06-11 18:57:17 +00:00 by a · 4 comments
a commented 2022-06-11 18:57:17 +00:00
Owner
Copy link

mx-puppet-discord is broken again, as expected (since it breaks all the freaking time). This is the error message:

Jun 11 13:55:44 exozyme sh[353656]: /usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/actions/MessageCreate.js:11
Jun 11 13:55:44 exozyme sh[353656]:       const existing = channel.messages.cache.get(data.id);
Jun 11 13:55:44 exozyme sh[353656]:                                         ^
Jun 11 13:55:44 exozyme sh[353656]: TypeError: Cannot read properties of undefined (reading 'cache')
Jun 11 13:55:44 exozyme sh[353656]:     at MessageCreateAction.handle (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/actions/MessageCreate.js:11:41)
Jun 11 13:55:44 exozyme sh[353656]:     at module.exports [as MESSAGE_CREATE] (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/handlers/MESSAGE_CREATE.js>
Jun 11 13:55:44 exozyme sh[353656]:     at WebSocketManager.handlePacket (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketManager.js:391:31)
Jun 11 13:55:44 exozyme sh[353656]:     at WebSocketShard.onPacket (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketShard.js:451:22)
Jun 11 13:55:44 exozyme sh[353656]:     at WebSocketShard.onMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketShard.js:308:10)
Jun 11 13:55:44 exozyme sh[353656]:     at WebSocket.onMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/event-target.js:132:16)
Jun 11 13:55:44 exozyme sh[353656]:     at WebSocket.emit (node:events:527:28)
Jun 11 13:55:44 exozyme sh[353656]:     at Receiver.receiverOnMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/websocket.js:1047:20)
Jun 11 13:55:44 exozyme sh[353656]:     at Receiver.emit (node:events:527:28)
Jun 11 13:55:44 exozyme sh[353656]:     at Receiver.dataMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/receiver.js:517:14)
Jun 11 13:55:44 exozyme sh[353656]: Node.js v18.3.0
Jun 11 13:55:44 exozyme systemd[1]: mx-puppet-discord.service: Main process exited, code=exited, status=1/FAILURE
mx-puppet-discord is broken again, as expected (since it breaks all the freaking time). This is the error message: ``` Jun 11 13:55:44 exozyme sh[353656]: /usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/actions/MessageCreate.js:11 Jun 11 13:55:44 exozyme sh[353656]: const existing = channel.messages.cache.get(data.id); Jun 11 13:55:44 exozyme sh[353656]: ^ Jun 11 13:55:44 exozyme sh[353656]: TypeError: Cannot read properties of undefined (reading 'cache') Jun 11 13:55:44 exozyme sh[353656]: at MessageCreateAction.handle (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/actions/MessageCreate.js:11:41) Jun 11 13:55:44 exozyme sh[353656]: at module.exports [as MESSAGE_CREATE] (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/handlers/MESSAGE_CREATE.js> Jun 11 13:55:44 exozyme sh[353656]: at WebSocketManager.handlePacket (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketManager.js:391:31) Jun 11 13:55:44 exozyme sh[353656]: at WebSocketShard.onPacket (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketShard.js:451:22) Jun 11 13:55:44 exozyme sh[353656]: at WebSocketShard.onMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/@mx-puppet/better-discord.js/src/client/websocket/WebSocketShard.js:308:10) Jun 11 13:55:44 exozyme sh[353656]: at WebSocket.onMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/event-target.js:132:16) Jun 11 13:55:44 exozyme sh[353656]: at WebSocket.emit (node:events:527:28) Jun 11 13:55:44 exozyme sh[353656]: at Receiver.receiverOnMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/websocket.js:1047:20) Jun 11 13:55:44 exozyme sh[353656]: at Receiver.emit (node:events:527:28) Jun 11 13:55:44 exozyme sh[353656]: at Receiver.dataMessage (/usr/lib/node_modules/mx-puppet-discord/node_modules/ws/lib/receiver.js:517:14) Jun 11 13:55:44 exozyme sh[353656]: Node.js v18.3.0 Jun 11 13:55:44 exozyme systemd[1]: mx-puppet-discord.service: Main process exited, code=exited, status=1/FAILURE ```
a added the
bug
 label 2022-06-11 18:57:17 +00:00
a added this to the (deleted) project 2022-06-11 18:57:19 +00:00
a commented 2022-06-11 19:05:26 +00:00
Author
Owner
Copy link

It's been reported upstream too: https://gitlab.com/mx-puppet/discord/mx-puppet-discord/-/issues/207

It's been reported upstream too: https://gitlab.com/mx-puppet/discord/mx-puppet-discord/-/issues/207
a commented 2022-06-11 19:39:49 +00:00
Author
Owner
Copy link

Attempting the fix suggested upstream causes the bridge to not crash but it also can't send messages to the Discord side (since that library is the buggy one). For now I modified to systemd service to auto-restart mx-puppet-discord if it crashes, which is a really bad solution but there's not much we can do about it.

Attempting the fix suggested upstream causes the bridge to not crash but it also can't send messages to the Discord side (since that library is the buggy one). For now I modified to systemd service to auto-restart mx-puppet-discord if it crashes, which is a really bad solution but there's not much we can do about it.
a closed this issue 2022-06-11 19:39:49 +00:00
a commented 2022-06-11 19:47:37 +00:00
Author
Owner
Copy link

Reopening since that solution above isn't a long-term fix.

Reopening since that solution above isn't a long-term fix.
a reopened this issue 2022-06-11 19:47:37 +00:00
a commented 2022-06-11 19:49:28 +00:00
Author
Owner
Copy link

Well it seems to work every few runs so I guess we'll just have to go with this "solution" for now and hope it gets fixed by upstream soon.

Well it seems to work every few runs so I guess we'll just have to go with this "solution" for now and hope it gets fixed by upstream soon.
a closed this issue 2022-06-11 19:49:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v9.0
v8.8
v8.7
v8.6
v8.5
v8.4
v8.3
v8.2
v8.1
v8.0
v7.10
v7.9
v7.8
v7.7
v7.6
v7.5
v7.4
v7.3
v7.2
v7.1
v7.0
v6.1
v6.0
v5.1
v5.0
v4.2
v4.1
v4.0
v3.0
v2.5
v2.4
v2.3
v2.2
v2.1
v2.0
v1.3
v1.2
v1.1
v1.0
v0.3-beta
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

Security vulnerability

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: exozyme/exozyme#152
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?