Chore: Listener should not expose original net.Listener

This commit is contained in:
Dreamacro 2021-06-13 23:05:22 +08:00
parent 6091fcdfec
commit f231a63e93
7 changed files with 33 additions and 33 deletions

View file

@ -17,10 +17,10 @@ import (
)
type Listener struct {
net.Listener
address string
closed bool
cache *cache.Cache
listener net.Listener
address string
closed bool
cache *cache.Cache
}
func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
@ -31,7 +31,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
hl := &Listener{l, addr, false, cache.New(30 * time.Second)}
go func() {
for {
c, err := hl.Accept()
c, err := hl.listener.Accept()
if err != nil {
if hl.closed {
break
@ -47,7 +47,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
func (l *Listener) Close() {
l.closed = true
l.Listener.Close()
l.listener.Close()
}
func (l *Listener) Address() string {

View file

@ -12,10 +12,10 @@ import (
)
type Listener struct {
net.Listener
address string
closed bool
cache *cache.Cache
listener net.Listener
address string
closed bool
cache *cache.Cache
}
func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
@ -27,7 +27,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
ml := &Listener{l, addr, false, cache.New(30 * time.Second)}
go func() {
for {
c, err := ml.Accept()
c, err := ml.listener.Accept()
if err != nil {
if ml.closed {
break
@ -43,7 +43,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
func (l *Listener) Close() {
l.closed = true
l.Listener.Close()
l.listener.Close()
}
func (l *Listener) Address() string {

View file

@ -8,9 +8,9 @@ import (
)
type Listener struct {
net.Listener
address string
closed bool
listener net.Listener
address string
closed bool
}
func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
@ -38,7 +38,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
func (l *Listener) Close() {
l.closed = true
l.Listener.Close()
l.listener.Close()
}
func (l *Listener) Address() string {

View file

@ -12,9 +12,9 @@ import (
)
type Listener struct {
net.Listener
address string
closed bool
listener net.Listener
address string
closed bool
}
func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
@ -42,7 +42,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
func (l *Listener) Close() {
l.closed = true
l.Listener.Close()
l.listener.Close()
}
func (l *Listener) Address() string {

View file

@ -12,9 +12,9 @@ import (
)
type UDPListener struct {
net.PacketConn
address string
closed bool
packetConn net.PacketConn
address string
closed bool
}
func NewUDP(addr string, in chan<- *inbound.PacketAdapter) (*UDPListener, error) {
@ -48,7 +48,7 @@ func NewUDP(addr string, in chan<- *inbound.PacketAdapter) (*UDPListener, error)
func (l *UDPListener) Close() error {
l.closed = true
return l.PacketConn.Close()
return l.packetConn.Close()
}
func (l *UDPListener) Address() string {

View file

@ -9,9 +9,9 @@ import (
)
type Listener struct {
net.Listener
address string
closed bool
listener net.Listener
address string
closed bool
}
func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
@ -32,7 +32,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
}
rl := &Listener{
Listener: l,
listener: l,
address: addr,
}
@ -54,7 +54,7 @@ func New(addr string, in chan<- C.ConnContext) (*Listener, error) {
func (l *Listener) Close() {
l.closed = true
l.Listener.Close()
l.listener.Close()
}
func (l *Listener) Address() string {

View file

@ -10,9 +10,9 @@ import (
)
type UDPListener struct {
net.PacketConn
address string
closed bool
packetConn net.PacketConn
address string
closed bool
}
func NewUDP(addr string, in chan<- *inbound.PacketAdapter) (*UDPListener, error) {
@ -61,7 +61,7 @@ func NewUDP(addr string, in chan<- *inbound.PacketAdapter) (*UDPListener, error)
func (l *UDPListener) Close() error {
l.closed = true
return l.PacketConn.Close()
return l.packetConn.Close()
}
func (l *UDPListener) Address() string {