exozyme/website
Archived
6
2
Fork 3
Code Issues Pull requests Projects Releases Wiki Activity

added margin to exohub image #10

Closed
codedotjs wants to merge 1 commit from codedotjs/website-exozyme:main into main
pull from: codedotjs/website-exozyme:main
merge into: exozyme:main
Conversation 6 Commits 1 Files changed 1 +1 -1
codedotjs commented 2022-05-25 14:04:31 +00:00
Owner
Copy link

I added margin: 0em 0em 1em 0em to the exohub image for the text not to continue below the image.

I added `margin: 0em 0em 1em 0em` to the exohub image for the text not to continue below the image.
👍 1
codedotjs added 1 commit 2022-05-25 14:04:31 +00:00
codedotjs commented 2022-05-25 14:05:25 +00:00
Author
Owner
Copy link

Just ignore the title of the commit. It sais that I added padding.

Just ignore the title of the commit. It sais that I added padding.
codedotjs commented 2022-05-25 14:09:02 +00:00
Author
Owner
Copy link

Note that this only works as long as the text is not longer than three lines. Therefore it is more like a temporary fix.

Note that this only works as long as the text is not longer than three lines. Therefore it is more like a temporary fix.
a commented 2022-05-25 15:20:52 +00:00
Owner
Copy link

@codedotjs Do the other images need the same margin to be applied? Also, the text is only two lines when I open the website on my computer, so I'm not sure what's going on there.

If we want to apply the same margin to all the images, we should probably create a class and apply CSS to that class on the style.css.

@codedotjs Do the other images need the same margin to be applied? Also, the text is only two lines when I open the website on my computer, so I'm not sure what's going on there. If we want to apply the same margin to all the images, we should probably create a class and apply CSS to that class on the `style.css`.
a commented 2022-05-25 21:57:32 +00:00
Owner
Copy link

@codedotjs I just pushed a big rewrite of our CSS, so does this issue still exist?

@codedotjs I just pushed a big rewrite of our CSS, so does this issue still exist?
a commented 2022-05-27 19:18:49 +00:00
Owner
Copy link

I'm closing this for now since it should be solved by the recent CSS rewrite. Please reopen this if the issue still exists!

I'm closing this for now since it *should* be solved by the recent CSS rewrite. Please reopen this if the issue still exists!
a closed this pull request 2022-05-27 19:18:49 +00:00
codedotjs commented 2022-05-30 18:57:06 +00:00
Author
Owner
Copy link

The issue seems to be solved.

The issue seems to be solved.
👍 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: exozyme/website#10
No description provided.
Delete branch "codedotjs/website-exozyme:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?